RT-1.15: Enhance addpath scale test with additional port descriptions and BGP session verification

[karthikeya-remilla]

draft code for debugging IXIA issues for RT-1.15

Facing these errors:
I0204 17:46:48.943748 14738 gnmi.go:285] Received gNMI SyncResponse.
arp.go:29: Did not receive OTG Neighbor entry for interface port1.Eth, last got:
--- FAIL: TestAddPathScale (144.10s)

[gemini-code-assist]

Summary of Changes

Hello @karthikeya-remilla, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the addpath scale test by adding port descriptions, BGP session verification, and increased ARP wait times. These changes aim to improve the reliability and debuggability of the test, addressing issues encountered with IXIA.

Highlights

• Port Descriptions: Added descriptions for DUT ports (port1, port2, port3, port4) to improve clarity and debugging.
• BGP Session Verification: Implemented verification of BGP sessions on both OTG and DUT to ensure proper establishment and stability.
• ARP Wait Time: Increased wait time for ARP resolution to enhance reliability, especially in scale tests.
• Dependency Injection: Added cfgplugins to the list of imported packages.

Changelog

• feature/bgp/addpath/otg_tests/addpath_scale/addpath_scale_test.go
  • Added descriptions to DUT port attributes.
  • Added BGP session verification for OTG and DUT.
  • Increased wait time for ARP resolution.
  • Imported cfgplugins package.
• feature/platform/fabric/otg_tests/fabric_redundancy_test/metadata.textproto
  • Fixed typo in comment.

Activity

• The pull request includes changes to the addpath scale test to address IXIA issues.
• The changes include adding port descriptions, BGP session verification, and increased ARP wait times.
• The pull request is marked as draft code for debugging purposes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces several changes. My review focuses on fixing a critical typo in metadata.textproto and removing commented-out code for better maintainability. The use of time.Sleep in OTG tests is considered an acceptable practice for consistency with existing implementations, as per repository rules, therefore comments suggesting its removal have been dropped. The other changes, such as adding WaitForARP calls, are reasonable for debugging purposes.

[gemini-code-assist]

There appears to be a stray 'g' character at the beginning of this line. This typo will likely cause parsing errors and should be removed.

Suggested change

	g# proto-file: github.com/openconfig/featureprofiles/proto/metadata.proto
	# proto-file: github.com/openconfig/featureprofiles/proto/metadata.proto

[gemini-code-assist]

This commented-out code should be removed before merging to improve code clarity and maintainability.

[coveralls]

Pull Request Test Coverage Report for Build 21671254295

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 9.915%

---

Totals
Change from base Build 21668235928:	0.0%
Covered Lines:	2247
Relevant Lines:	22662

---

💛 - Coveralls