Added CommitSetRollbackDuration action for Commit Confirmed extension#164
Merged
dplore merged 2 commits intoopenconfig:masterfrom Feb 23, 2024
Merged
Conversation
Contributor
Author
Contributor
|
LGTM. Please update https://github.com/openconfig/reference/blob/master/rpc/gnmi/gnmi-commit-confirmed.md as well. |
Contributor
Author
Thanks @kidiyoor , raised openconfig/reference#203 for this |
Member
|
This is a last call for comments. This is planned to merge on Feb 15, 2024. |
dplore
previously approved these changes
Feb 2, 2024
Contributor
Author
Contributor
Author
|
Hi @dplore |
dplore
approved these changes
Feb 23, 2024
Member
Thanks for the ping! |
Member
|
This should have been merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative version to #161.
In this version, a specific action is added to denote the Set Rollback Duration for the Commit Confirmed action.