Skip to content

Conversation

@jlost
Copy link

@jlost jlost commented Dec 3, 2025

Motivation

Upon building Dockerfile, build fails because latest version of google.golang.org/grpc/cmd/protoc-gen-go-grpc requires a higher golang version than is specified in the Dockerfile/go.mod.

Modifications

Pins google.golang.org/grpc/cmd/protoc-gen-go-grpc to the latest version compatible with go 1.23.

Result

docker build completes successfully.

Summary by CodeRabbit

  • Chores
    • Pinned and clarified build tooling versions for code generation to improve reproducible builds, added runtime/version checks and a compatibility note for newer runtime versions to reduce build inconsistencies.

✏️ Tip: You can customize this high-level summary in your review settings.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 3, 2025

@jlost: This pull request references RHOAIENG-41310 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

Motivation

Upon building Dockerfile, build fails because latest version of google.golang.org/grpc/cmd/protoc-gen-go-grpc requires a higher golang version than is specified in the Dockerfile/go.mod.

Modifications

Pins google.golang.org/grpc/cmd/protoc-gen-go-grpc to the latest version compatible with go 1.23.

Result

docker build completes successfully.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link

coderabbitai bot commented Dec 3, 2025

Walkthrough

The Dockerfile's tool installation was changed: the unversioned go get for protoc-gen-go-grpc was removed and replaced with an explicit go install google.golang.org/grpc/cmd/[email protected]; version-check commands for the generated tools were added/adjusted.

Changes

Cohort / File(s) Summary
gRPC dependency versioning
Dockerfile
Removed unversioned go get google.golang.org/grpc/cmd/protoc-gen-go-grpc; added pinned go install google.golang.org/grpc/cmd/[email protected]; added/updated version-check commands and explanatory comment about separate module/versioning and Go toolchain compatibility.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single-file change focused on dependency installation commands and comments.
  • Review attention: confirm exact @v1.5.1 version and version-check commands behave in target Go runtime.

Poem

🐰 I hopped into the build at dawn,
Replaced a float with a steady pawn,
Pinned a friend to v1.5.1,
Now the compile waltz runs smooth and fun,
Tiny changes, tidy grin — containers on! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically references the main change: pinning protoc-gen-go-grpc to a version compatible with the Go version constraint.
Description check ✅ Passed The description includes all required template sections (Motivation, Modifications, Result) with complete and relevant information addressing the build issue and solution.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad9f839 and 7c52a1d.

📒 Files selected for processing (1)
  • Dockerfile (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Dockerfile
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 3, 2025

@jlost: This pull request references RHOAIENG-41310 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

Motivation

Upon building Dockerfile, build fails because latest version of google.golang.org/grpc/cmd/protoc-gen-go-grpc requires a higher golang version than is specified in the Dockerfile/go.mod.

Modifications

Pins google.golang.org/grpc/cmd/protoc-gen-go-grpc to the latest version compatible with go 1.23.

Result

docker build completes successfully.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jlost jlost marked this pull request as ready for review December 3, 2025 20:46
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 3, 2025

@jlost: This pull request references RHOAIENG-41310 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

Motivation

Upon building Dockerfile, build fails because latest version of google.golang.org/grpc/cmd/protoc-gen-go-grpc requires a higher golang version than is specified in the Dockerfile/go.mod.

Modifications

Pins google.golang.org/grpc/cmd/protoc-gen-go-grpc to the latest version compatible with go 1.23.

Result

docker build completes successfully.

Summary by CodeRabbit

  • Chores
  • Updated build infrastructure dependencies with explicit versioning to ensure improved consistency and reliability across builds.

✏️ Tip: You can customize this high-level summary in your review settings.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Dec 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 3, 2025

@jlost: This pull request references RHOAIENG-41310 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

Motivation

Upon building Dockerfile, build fails because latest version of google.golang.org/grpc/cmd/protoc-gen-go-grpc requires a higher golang version than is specified in the Dockerfile/go.mod.

Modifications

Pins google.golang.org/grpc/cmd/protoc-gen-go-grpc to the latest version compatible with go 1.23.

Result

docker build completes successfully.

Summary by CodeRabbit

  • Chores
  • Pinned and clarified build tooling versions for code generation to improve reproducible builds, added runtime/version checks and a compatibility note for newer runtime versions to reduce build inconsistencies.

✏️ Tip: You can customize this high-level summary in your review settings.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@spolti
Copy link
Member

spolti commented Dec 3, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 3, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlost, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d33966c into opendatahub-io:main Dec 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants