Skip to content

feat: added option to override default preferences #37807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AhtishamShahid merged 2 commits into from
Dec 24, 2025
Merged

feat: added option to override default preferences #37807

AhtishamShahid merged 2 commits into from
Dec 24, 2025
+298 −2

Conversation

@AhtishamShahid
Copy link
Contributor

@AhtishamShahid AhtishamShahid commented Dec 23, 2025 •
edited
Loading

This PR introduces Django settings to override default notification preferences for types and apps, allowing admins to customize channels (web, email, push) and enforce non-editable settings without code changes.

Key changes:

  • Refactor constants to use getters with overrides.
  • Add settings: NOTIFICATION_TYPES_OVERRIDE and NOTIFICATION_APPS_OVERRIDE .
  • Safe override logic: whitelisted keys, deep copies, ignore unknowns.
  • New docs in settings.md with examples.
  • Unit tests for overrides, edges, and immutability.

@AhtishamShahid AhtishamShahid merged commit 432926d into master Dec 24, 2025
69 checks passed
@AhtishamShahid AhtishamShahid deleted the ahtisham/notification-pref-overrides branch December 24, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@muhammadadeeltajamul muhammadadeeltajamul muhammadadeeltajamul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AhtishamShahid @muhammadadeeltajamul