Move available_translations into VideoConfigService #37808
+100
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhan
force-pushed
the
farhan/move-available-translations
branch
from
4eb5548 to
5b237b8
Compare
farhan
added
the
create-sandbox
feanil
reviewed
Dec 23, 2025
Contributor
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
Generally makes sense, let me know once you've added your testing notes and I can do a final review.
|
Sandbox deployment successful 🚀 |
farhan
force-pushed
the
farhan/move-available-translations
branch
from
5b237b8 to
804a91f
Compare
|
Sandbox deployment successful 🚀 |
farhan
force-pushed
the
farhan/move-available-translations
branch
from
804a91f to
bf24571
Compare
This moves edx-platform-specific logic out of the VideoBlock, in preparation for the VideoBlock extraction: #36282
farhan
force-pushed
the
farhan/move-available-translations
branch
from
bf24571 to
3a9baa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves edx-platform-specific logic out of the VideoBlock, in preparation for the VideoBlock extraction:
#36282
Testing instructions
point where available_translation method calls as a fallback on error.
I have manually called the required javascript function by adding test code in this file to hit the
available_translationsfunction and tested the api on my local machine.Here are the results:
Following are the screenshots of the sanbox created within this PR: