feat: New library sync icon #2739
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2739 +/- ##
==========================================
+ Coverage 94.88% 94.90% +0.01%
==========================================
Files 1236 1235 -1
Lines 28102 28281 +179
Branches 6206 6418 +212
==========================================
+ Hits 26664 26839 +175
+ Misses 1380 1371 -9
- Partials 58 71 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rpenido
left a comment
rpenido
left a comment
There was a problem hiding this comment.
LGTM 👍
Thank you for your work, @ChrisChV!
- I tested this using the instructions from the PR
- I read through the code
- I checked for accessibility issues
- Includes documentation
I added one comment about the title alignment on the UnitCard (not totally related to this code).
bradenmacdonald
left a comment
bradenmacdonald
left a comment
There was a problem hiding this comment.
Approved, but with some suggestions
| let hasTwoIcons = false; | ||
| let secondIconProps = {}; |
There was a problem hiding this comment.
Nit: personally, instead of two separate variables, I would just put
let secondIcon: JSX.Element | undefined;
...
secondIcon = (
<Icon
size={size}
title={intl.formatMessage(messages.upstreamLinkError)}
ariaLabel={intl.formatMessage(messages.upstreamLinkError)}
src={LinkOff}
/>
);- {hasTwoIcons && (
- <Icon
- size={size}
- {...secondIconProps}
- />
- )}
+ {secondIcon}| tooltipMessage = intl.formatMessage(messages.upstreamLinkError); | ||
| secondIconProps = { | ||
| title: intl.formatMessage(messages.upstreamLinkError), | ||
| ariaLabel: intl.formatMessage(messages.upstreamLinkError), |
There was a problem hiding this comment.
With the change I suggested above, TypeScript is warnings that it should be aria-label not ariaLabel. Whichever approach you use, please check that the prop is right and make sure the aria-label is actually showing up in the final HTML.
| color: white; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
| // Sizes with one icon: |
| width: 28px; | ||
| height: 22px; | ||
| } | ||
|
|
There was a problem hiding this comment.
| // Sizes with two icons: |
5 participants
Description
Supporting information
Testing instructions
Other information
N/A
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'