Skip to content

use template store pull in build for fetching the configured template before default templates #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use template store pull in build for fetching the configured template before default templates #965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions commands/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,8 @@ func runBuild(cmd *cobra.Command, args []string) error {
return fmt.Errorf("could not pull templates from function yaml file: %s", err.Error())
}
} else {
templateAddress := getTemplateURL("", os.Getenv(templateURLEnvironment), DefaultTemplateRepository)
if pullErr := pullTemplates(templateAddress); pullErr != nil {
return fmt.Errorf("could not pull templates for OpenFaaS: %v", pullErr)
for _, function := range services.Functions {
runTemplateStorePull(cmd, []string{function.Language})
Copy link
Contributor Author

@NikhilSharmaWe NikhilSharmaWe Jun 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexellis Just informing you that I'm a little busy with my exams this week, so I'll be able to test the scenarios for these changes after this week.

Thank you

}
}
if len(services.Functions) == 0 {
Expand Down