Use QNetworkInformation to queue QFieldCloud pushes offline and resume when back online #6879
+113
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…push the changes as soon as the network is available
Collaborator
|
🎉 Ta-daaa, freshly created APKs are available for 53d278a: arm64-android |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mohsenD98
reviewed
Dec 12, 2025
|
|
||
| const int mProjectsPerFetch = 250; | ||
|
|
||
| bool networkLooksActive() const; |
Collaborator
There was a problem hiding this comment.
I have one minor naming suggestion regarding the networkLooksActive() method.
Since the method is actually checking QNetworkInformation::reachability(), a name that reflects the reachability aspect might make the intent clearer to future readers.
Something like isReachableToCloud()
Collaborator
Author
There was a problem hiding this comment.
Surely, thankyou for the input @mohsenD98 😄
Collaborator
🍎 MacOS DMG universal buildsDownload a MacOS DMG universal build of this PR for testing. 🐧 Linux AppImage buildsDownload a Linux AppImage build of this PR for testing. 🪟 Windows buildsDownload a Windows build of this PR for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a small push-queue mechanism to QFieldCloudConnection so that when the device is offline (or reachability is not confirmed), project push requests are queued and automatically retried once the connection becomes reachable again.
Uses QNetworkInformation::Reachability to detect online/offline transitions
Introduces queueProjectPush(), tryFlushQueuedProjectPushes() in QFieldCloudConnection
Emits queuedProjectPush(projectId, shouldDownloadUpdates) when flushing, and QFieldCloudProjectsModel listens to it to trigger projectPush()
Keeps behavior unchanged when no reachability backend is available (falls back to “online”)
trim.B5710F20-5268-4E78-8300-522A412331F3.MOV