Skip to content

names: Stab at fixing some non-determinism in pick_case #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pudo merged 1 commit into from
Mar 6, 2026
Merged

names: Stab at fixing some non-determinism in pick_case #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rigour/names/pick.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,8 @@ def pick_case(names: List[str]) -> str:
if len(scores) == 0:
raise ValueError("Names could not be scored: %r" % names)

return min(scores.items(), key=lambda i: (i[1], len(i[0])))[0]
# Sort by score, then by length (shortest wins), then lexicographically
return min(scores.items(), key=lambda i: (i[1], len(i[0]), i[0]))[0]


def reduce_names(names: List[str], require_names: bool = False) -> List[str]:
Expand Down