Open
Conversation
Member
|
@kalynstricklin The I think in your case you could create a module called |
Contributor
Author
|
perf! thank you! |
earocorn
requested changes
Dec 10, 2025
| @@ -0,0 +1,210 @@ | |||
| package com.botts.impl.comm.mqtt; | |||
Collaborator
There was a problem hiding this comment.
add license headers to files
| } | ||
|
|
||
| /** | ||
| * |
Collaborator
There was a problem hiding this comment.
Fill in all the javadoc blocks or just remove them
| @DisplayInfo(label="Retain", desc="Check to allow MQTT broker to store the last message sent on the specific topic") | ||
| public boolean retain; | ||
|
|
||
| @DisplayInfo(label="Clean Session", desc="Check ") |
Collaborator
There was a problem hiding this comment.
Maybe add real descriptions to these or remove
| @@ -1,6 +1,19 @@ | |||
| description = 'MQTT Service API' | |||
Collaborator
There was a problem hiding this comment.
I think you should restore this to its previous version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.