Conversation
| SWEHelper fac = new SWEHelper(); | ||
| // The Master Control Data Structure is a Choice of individual controls for the KrakenSDR | ||
| commandDataStruct = fac.createRecord() | ||
| .name("DoA_control") |
There was a problem hiding this comment.
If you are updating the styling of the field names, you will probably want to update the control/output names as well. This should match the name that is passed into the super-class constructor above on line 19, so you may want to update those to match.
| util.uploadSettings(currentSettings); | ||
| }catch (SensorHubException e){ | ||
| getLogger().error("Kraken settings upload failed", e); | ||
| throw new CommandException("Kraken settings upload failed", e); |
There was a problem hiding this comment.
The exception should get logged when thrown, so you are probably logging this twice
| } catch (SensorHubException e) { | ||
| throw new RuntimeException(e); | ||
| getLogger().debug("Failed to retrieve current json settings from kraken: ", e); | ||
| throw new CommandException("Unable to retrieve Kraken settings.json", e); |
| .addField("latitude", fac.createText() | ||
| .label("Latitude") | ||
| .description("Latitude when station is Static") | ||
| .definition(SWEHelper.getPropertyUri("latitude")) |
There was a problem hiding this comment.
Lat and lon have standard SWE definitions that we use on clients to search for LLA / LL datastreams. You may want to check GeoPosHelper for those definitions, or just use the createLocationVectorLatLon() from GeoPosHelper
| @@ -30,26 +25,23 @@ public class KrakenSdrSensor extends AbstractSensorModule<KrakenSdrConfig> imple | |||
| static final String UID_PREFIX = "osh:krakenSDR:"; | |||
There was a problem hiding this comment.
Could you use the standard UID prefix for most sensors which I believe would be urn:osh:sensor:krakensdr:
| @@ -29,7 +29,7 @@ To begin these steps, logon to your Raspberry Pi and begin: | |||
| ``` | |||
| 2. Make sure java 17 is installed on raspberry pi | |||
There was a problem hiding this comment.
The instructions say to install 17 but the command is to install openjdk 21
| id 'krakenSDR' | ||
| id 'krakensdr' | ||
| name 'Bill Brown' | ||
| organization 'Botts-inc' |
There was a problem hiding this comment.
We may want to update org / website to reflect org change, but not sure since it was originally created at Botts inc. Maybe ask Nick or Drew about this
2 participants
Updated the Kraken Driver. Made Modifications to the KrakenUtility class to handle different outputs the Kraken Software provides for obtaining DoA. Updated Version numbering and reduced vulnerabilities.