Merged
Conversation
nickgaray
reviewed
Feb 23, 2026
Collaborator
nickgaray
left a comment
nickgaray
left a comment
There was a problem hiding this comment.
Does this mean then that logging still occurs on host machine but also as an output?
Robin White had implemented a system monitor driver, should that be merged with this?
.../sensorhub-driver-logback/src/main/java/org/sensorhub/impl/sensor/logback/LogbackDriver.java
Outdated
Show resolved
Hide resolved
...orhub-driver-logback/src/main/java/org/sensorhub/impl/sensor/logback/LogbackEventOutput.java
Show resolved
Hide resolved
.../sensorhub-driver-logback/src/main/java/org/sensorhub/impl/sensor/logback/LogbackDriver.java
Show resolved
Hide resolved
Collaborator
Author
|
Checked with Robin and the system monitor driver is out of date (Java 11) so I think it would be easiest to keep these separate for now, possibly with a future integration |
nickgaray
requested changes
Feb 23, 2026
Collaborator
nickgaray
left a comment
nickgaray
left a comment
There was a problem hiding this comment.
Definitions have to be URIs, see comment for "definition" of data record
...orhub-driver-logback/src/main/java/org/sensorhub/impl/sensor/logback/LogbackEventOutput.java
Show resolved
Hide resolved
nickgaray
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a driver that outputs server logs using a logback
Appenderimplementation