HttpClientWrapper to use switch between using Java Http and Ok Http for android#335
Open
kalynstricklin wants to merge 9 commits intoopensensorhub:masterfrom
Open
HttpClientWrapper to use switch between using Java Http and Ok Http for android#335kalynstricklin wants to merge 9 commits intoopensensorhub:masterfrom
kalynstricklin wants to merge 9 commits intoopensensorhub:masterfrom
Conversation
kalynstricklin
commented
Feb 18, 2026
kalynstricklin
commented
- Added httpclientwrapper to use java or okhttp during runtime based on httpclient availability
- Added oauth
- Added register system datastreams to update existing datastreams instead of creating new ones
…er system datastreams, reverted back to using foi id and obsstore
…access to an obs store
…plement android ok http wrapper or javahttpwrapper by default
earocorn
reviewed
Feb 20, 2026
...ice-consys/src/main/java/org/sensorhub/impl/service/consys/client/ConSysApiClientModule.java
Show resolved
Hide resolved
| import org.sensorhub.impl.service.consys.client.ConSysApiClientConfig; | ||
| import org.sensorhub.impl.service.consys.resource.ResourceFormat; | ||
|
|
||
| public interface IHttpClient |
There was a problem hiding this comment.
We should probably make this more generic for a range of uses. For example, a driver could use this to send GET requests for sensor data and be compatible with Android by default. It also may be a good idea to have the client API and implementation live in sensorhub-core, but I'm not 100% sure
...e-consys/src/main/java/org/sensorhub/impl/service/consys/client/http/IHttpURLConnection.java
Outdated
Show resolved
Hide resolved
...ice-consys/src/main/java/org/sensorhub/impl/service/consys/client/ConSysApiClientModule.java
Outdated
Show resolved
Hide resolved
...ice-consys/src/main/java/org/sensorhub/impl/service/consys/client/ConSysApiClientConfig.java
Show resolved
Hide resolved
We cannot guarantee that the foi id on the local observations are the same as the ones registered on the remote node
Author
|
@earocorn Can you leave input on the foi id additions |
|
This re-adds logic to use FOI IDs that are created on the remote node, since we can't guarantee that both nodes use the same ID encoders / encoding mechanism (db vs no db). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.