Skip to content

HYPERFLEET-645 - fix: Change owned_reference to owner_references #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Feb 24, 2026
Merged

HYPERFLEET-645 - fix: Change owned_reference to owner_references #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ test.out.json
broker/test.out.json
example/bin
.tool-versions

# Claude Code local config
.claude/
2 changes: 1 addition & 1 deletion example/cloudevent.example.nodepool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"kind": "NodePool",
"href": "https://api.hyperfleet.com/v1/clusters/11111111-1111-1111-1111-111111111111/nodepools/22222222-2222-2222-2222-222222222222",
"generation": 5,
"owned_reference": {
"owner_references": {
Copy link
Contributor

@rafabene rafabene Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I noticed that the https://github.com/openshift-hyperfleet/architecture/blob/main/hyperfleet/components/broker/asyncapi.yaml defines this field as owned_reference (singular) — it's listed as a required field in the ReconcileNodePool schema.

If the actual API returns owner_references, then we should also update the AsyncAPI spec to
stay in sync. Otherwise we'll have the example saying one thing and the spec saying another,
which is the same kind of inconsistency this PR is trying to fix.

Could we confirm against the real API response and, if needed, open a follow-up to update the
spec?

Copy link
Contributor Author

@Mischulee Mischulee Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We confirmed the API uses owner_references in https://github.com/openshift-hyperfleet/hyperfleet-api-spec/blob/main/models/nodepools/model.tsp#L50.

Follow-up PRs were merged - updated the AsyncAPI spec, adapter code, and docs to match. Everything is now consistent.

"id": "11111111-1111-1111-1111-111111111111",
"kind": "Cluster",
"href": "https://api.hyperfleet.com/v1/clusters/11111111-1111-1111-1111-111111111111"
Expand Down