OCPCRT-436: Add request/revoke commands for temporary GCP project access

[AlexNPavel]

Add new request and revoke text commands that allow members of the
Hybrid Platforms organization to obtain temporary access to GCP projects
for testing complex or long-lived clusters beyond what the existing
automated commands support.

Commands:

• request <resource> "<justification>" - Request 7-day access with business justification
• revoke <resource> - Remove access early before expiration

Key features:

• Authorization via Cyborg API to verify Hybrid Platforms organization membership
• Service account-based access with key file distribution via Slack
• Automated IAM binding creation with 7-day default expiration
• Background monitoring and cleanup of expired access grants
• Initial support for "gcp-access" resource with extensible design

Implementation includes:

• New GCP access manager with IAM policy management (pkg/manager/gcp_access.go)
• Service account creation, key generation, and cleanup operations
• Request/revoke command parsers and action handlers
• BigQuery audit logging for access grants
• Comprehensive test coverage (627 lines of manager tests, 941 lines of Slack action tests)
• Documentation in docs/claude/OCPCRT-436/ for implementation details and testing procedures

This PR also includes modernization recommendations from the gopls modernizer.

[openshift-ci-robot]

@AlexNPavel: This pull request references OCPCRT-436 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Add new request and revoke text commands that allow members of the Hybrid Platforms organization to obtain temporary access to GCP projects for testing complex or long-lived clusters beyond what the existing automated commands support.

Commands:

• request <resource> "<justification>" - Request 7-day access with business justification
• revoke <resource> - Remove access early before expiration

Key features:

• Authorization via Cyborg API to verify Hybrid Platforms organization membership
• Automated IAM binding creation with 7-day default expiration
• Background monitoring and cleanup of expired access grants
• Initial support for "gcp-access" resource with extensible design for additional GCP projects or resource types

Implementation includes:

• New GCP access manager with IAM policy management (pkg/manager/gcp_access.go)
• Request/revoke command parsers and action handlers
• Comprehensive test coverage (627 lines of manager tests, 941 lines of Slack action tests)
• Documentation in docs/claude/OCPCRT-436/ for implementation details and testing procedures

This PR also has a modernization recommendations from the gopls modernizer implemented.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[AlexNPavel]

/hold

[AlexNPavel]

The lint test requires openshift/release#73653 to update golangci-lint to v2.

[AlexNPavel]

/retest

[openshift-ci-robot]

@AlexNPavel: This pull request references OCPCRT-436 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Add new request and revoke text commands that allow members of the
Hybrid Platforms organization to obtain temporary access to GCP projects
for testing complex or long-lived clusters beyond what the existing
automated commands support.

Commands:

• request <resource> "<justification>" - Request 7-day access with business justification
• revoke <resource> - Remove access early before expiration

Key features:

• Authorization via Cyborg API to verify Hybrid Platforms organization membership
• Service account-based access with key file distribution via Slack
• Automated IAM binding creation with 7-day default expiration
• Background monitoring and cleanup of expired access grants
• Initial support for "gcp-access" resource with extensible design

Implementation includes:

• New GCP access manager with IAM policy management (pkg/manager/gcp_access.go)
• Service account creation, key generation, and cleanup operations
• Request/revoke command parsers and action handlers
• BigQuery audit logging for access grants
• Comprehensive test coverage (627 lines of manager tests, 941 lines of Slack action tests)
• Documentation in docs/claude/OCPCRT-436/ for implementation details and testing procedures

This PR also includes modernization recommendations from the gopls modernizer.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bradmwilliams]

Definitely think we should consider refactoring the parser.SlackClient piece at some point, but it's not critical to this effort.

[AlexNPavel]

/retest

[AlexNPavel]

/label tide/merge-method-squash

[AlexNPavel]

I rebased onto main and updated the hack/govulncheck-wrapper.sh to use -tags gcs.

[openshift-ci]

@AlexNPavel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	dad9962	link	false	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexNPavel, bradmwilliams

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [AlexNPavel,bradmwilliams]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment