Skip to content

Conversation

@cristianoveiga
Copy link
Contributor

@cristianoveiga cristianoveiga commented Nov 11, 2025

Add gcp-approvers, gcp-reviewers to OWNERS files.

Modelled on kubevirt and OpenStack approaches.

What this PR does / why we need it:

Enables Prow automation to select appropriate GCP reviewers and grants GCP team /lgtm permissions for their code areas

Which issue(s) this PR fixes:

Fixes GCP-230

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2025

@cristianoveiga: This pull request references GCP-230 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Add gcp-reviewers to OWNERS files.

Modelled on kubevirt and OpenStack approaches.

What this PR does / why we need it:

Enables Prow automation to select appropriate GCP reviewers and grants GCP team /lgtm permissions for their code areas

Which issue(s) this PR fixes:

Fixes GCP-230

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-area labels Nov 11, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 11, 2025

Walkthrough

Adds four GCP-specific ownership filter patterns to OWNERS and two alias groups (gcp-approvers, gcp-reviewers) with four members each in OWNERS_ALIASES.

Changes

Cohort / File(s) Summary
GCP Ownership Configuration
OWNERS
Added four new filter patterns: combined top-level commands pattern (`cmd
GCP Alias Definitions
OWNERS_ALIASES
Added gcp-approvers and gcp-reviewers alias groups, each containing members: apahim, cblecker, ckandag, cristianoveiga.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify the regex patterns match intended paths and avoid unintended overlaps with existing filters.
  • Confirm alias keys exactly match the group names referenced in OWNERS.
  • Check the alias member list for correctness.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 84d1414 and cf92542.

📒 Files selected for processing (2)
  • OWNERS (1 hunks)
  • OWNERS_ALIASES (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • OWNERS_ALIASES
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • OWNERS
🔇 Additional comments (5)
OWNERS (5)

13-13: Clear section documentation.

The comment appropriately labels the GCP ownership section, consistent with the Konflux and KubeVirt sections.


19-23: API pattern is straightforward and correct.

This pattern will correctly match GCP-specific files under the api/ directory. Note that this provides more granular ownership than the kubevirt and openstack sections, which don't have separate api/ patterns. This additional specificity should help ensure appropriate GCP team review of API changes.


24-28: Documentation pattern looks good.

The pattern will correctly route GCP-specific documentation to the GCP team for review. This granular approach ensures domain expertise is applied to documentation changes.


29-33: Test pattern is correct.

The pattern appropriately matches GCP-specific test files. This will ensure the GCP team reviews changes to their test coverage. The pattern is well-formed and follows the same granular approach as the api and docs patterns.


14-18: Aliases are properly defined—code changes are approved.

Both gcp-approvers and gcp-reviewers are correctly configured in OWNERS_ALIASES with the same four members (apahim, cblecker, ckandag, cristianoveiga). The GCP pattern at lines 14-18 is valid and follows the established precedent for kubevirt and openstack patterns.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2025

@cristianoveiga: This pull request references GCP-230 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Add gcp-reviewers to OWNERS files.

Modelled on kubevirt and OpenStack approaches.

What this PR does / why we need it:

Enables Prow automation to select appropriate GCP reviewers and grants GCP team /lgtm permissions for their code areas

Which issue(s) this PR fixes:

Fixes GCP-230

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

Please specify an area label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cristianoveiga
Once this PR has been reviewed and has the lgtm label, please assign csrwng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cristianoveiga cristianoveiga changed the title GCP-230: Add gcp-reviewers to OWNERS files GCP-230: Add gcp-approvers, gcp-reviewers to OWNERS files Nov 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2025

@cristianoveiga: This pull request references GCP-230 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Add gcp-approvers, gcp-reviewers to OWNERS files.

Modelled on kubevirt and OpenStack approaches.

What this PR does / why we need it:

Enables Prow automation to select appropriate GCP reviewers and grants GCP team /lgtm permissions for their code areas

Which issue(s) this PR fixes:

Fixes GCP-230

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cristianoveiga cristianoveiga marked this pull request as ready for review November 11, 2025 21:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2025
@openshift-ci openshift-ci bot requested review from jparrill and muraee November 11, 2025 21:13
@cristianoveiga
Copy link
Contributor Author

/retest-required

Modelled on kubevirt and OpenStack approaches.
Include cblecker in both owners and approvers lists.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2025

@cristianoveiga: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-upgrade-hypershift-operator cf92542 link true /test e2e-aws-upgrade-hypershift-operator
ci/prow/e2e-kubevirt-aws-ovn-reduced cf92542 link true /test e2e-kubevirt-aws-ovn-reduced
ci/prow/okd-scos-e2e-aws-ovn cf92542 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aks cf92542 link true /test e2e-aks
ci/prow/e2e-aws cf92542 link true /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cristianoveiga
Copy link
Contributor Author

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-area jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants