CMP-3230: Test CO PCI-DSS profiles on ARM#68636
CMP-3230: Test CO PCI-DSS profiles on ARM#68636rhmdnd wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rhmdnd: This pull request references CMP-3230 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
cc: @Anna-Koudelkova @yuumasato @Vincent056 this should get PCI DSS profiles running on ARM clusters. |
openshift-ci
bot
added
the
approved
|
/pj-rehearse |
|
@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
We might not need to wait for ComplianceAsCode/content#13833 to land since we're using |
|
FIO, SPO, and CSO remediations failed because those operators aren't supported on ARM, yet. |
|
E2E-FAILURE: The expected remediated result for the e2e-pci-dss-audit-log-forwarding-enabled rule didn't match. |
|
ComplianceAsCode/content#13837 updates the assertions so this rehearsal passes. |
I guess it makes sense to set those rules as not applicable for ARM? |
I'm not sure I've hit a case where users have done that, so I expect it would be rare? In that case, I think it would be ok to exclude the rule if they decide to install from upstream. |
|
/pj-rehearse |
|
@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Clean run on the new rehearsals so I'm going to ack it since the last update was just a rebase. /pj-rehearse ack |
|
@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
openshift-ci-robot
removed
the
rehearsals-ack
|
/pj-rehearse |
|
@yuumasato: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
yuumasato
left a comment
yuumasato
left a comment
There was a problem hiding this comment.
/lgtm
Looks like it needs a rebase though
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
openshift-ci-robot
removed
the
rehearsals-ack
|
/lgtm |
openshift-merge-robot
added
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056, yuumasato The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Testing on ARM is necessary to support this profile by default. Adding these jobs will make it easier for us to suss out any issues with how rules behave on that architecture.
openshift-merge-robot
removed
the
needs-rebase
|
New changes are detected. LGTM label has been removed. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@xiaojiey: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@rhmdnd: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Issues in openshift/release go stale after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Stale issue in openshift/release rot after 15d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues in openshift/release close after 15d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
Testing on ARM is necessary to support this profile by default. Adding
these jobs will make it easier for us to suss out any issues with how
rules behave on that architecture.