Skip to content

Conversation

@vooon
Copy link
Contributor

@vooon vooon commented Jan 22, 2026

📦 Package Details

Maintainer: @vooon

Description:


🧪 Run Testing Details

  • OpenWrt Version: SNAPSHOT
  • OpenWrt Target/Subtarget: x86/64
  • OpenWrt Device: KVM

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

@vooon
Copy link
Contributor Author

vooon commented Jan 22, 2026

But it's actually more about Go 1.25.6 (#28378), than anything in CoreDNS itself.

@GeorgeSapkin
Copy link
Member

Can you please add these in this PR?

index 3ec5b3f70..c55f1e1ac 100644
--- a/net/coredns/Makefile
+++ b/net/coredns/Makefile
@@ -83,6 +83,7 @@ define Build/Configure
        cd $(PKG_BUILD_DIR); \
        $(GO_GENERAL_BUILD_CONFIG_VARS) \
        $(GO_PKG_BUILD_CONFIG_VARS) \
+       $(GO_PKG_VARS) \
        go generate coredns.go
 
        # NOTE: custom plugins needs go get to pull new dependencies
@@ -90,6 +91,7 @@ ifeq ($(CONFIG_COREDNS_REQUIRE_GO_GET),y)
        cd $(PKG_BUILD_DIR); \
        $(GO_GENERAL_BUILD_CONFIG_VARS) \
        $(GO_PKG_BUILD_CONFIG_VARS) \
+       $(GO_PKG_VARS) \
        go get ./...
 endif

This is going to break without these changes after:

@vooon
Copy link
Contributor Author

vooon commented Jan 22, 2026

@GeorgeSapkin done.

@GeorgeSapkin
Copy link
Member

Was MIPS an issue before?

@vooon
Copy link
Contributor Author

vooon commented Jan 22, 2026

2026-01-22T17:04:53.9630817Z fork/exec /builder/tmp/go-build585683556/b001/exe/directives_generate: exec format error
2026-01-22T17:04:54.0169020Z coredns.go:3: running "go": exit status 1

Looks like something have changed in Go.
Earlier toady build have passed: https://github.com/openwrt/packages/actions/runs/21249216541

@GeorgeSapkin
Copy link
Member

Ah, I guess go generate doesn't need target vars, so it shouldn't see GO_PKG_VARS. I guess this needs another way to pass the correct path.

Release note: https://coredns.io/2026/01/15/coredns-1.14.-release/

Co-authored-by: George Sapkin <george@sapk.in>
Signed-off-by: Vladimir Ermakov <vooon341@gmail.com>
@GeorgeSapkin GeorgeSapkin merged commit 19dd33d into openwrt:master Jan 23, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants