Skip to content

prosody: fix build, bump to to 0.12.6 and add test.sh#29286

Merged
commodo merged 1 commit intoopenwrt:masterfrom
commodo:fix-prosody-again
May 6, 2026
Merged

prosody: fix build, bump to to 0.12.6 and add test.sh#29286
commodo merged 1 commit intoopenwrt:masterfrom
commodo:fix-prosody-again

Conversation

@commodo
Copy link
Copy Markdown
Contributor

@commodo commodo commented May 2, 2026

📦 Package Details

Maintainer: Thomas Heil

Description:

mod_s2s was refactored into a single mod_s2s.lua in the flat modules directory in 0.12.x; remove the obsolete subdirectory install rule that caused the package build to fail.

Also add util/human/ and util/prosodyctl/ which are new subdirectories in 0.12.x not covered by the previous install rules.

Force libidn instead of ICU for stringprep

prosody's configure script auto-detects stringprep backends and prefers ICU when available, generating -DUSE_STRINGPREP_ICU and including <unicode/usprep.h>. The OpenWrt SDK staging directory does not provide ICU development headers, so the build fails with:

encodings.c:271:10: fatal error: unicode/usprep.h: No such file or directory

The Makefile DEPENDS already declares +libidn. Pass --with-idn=idn to explicitly select the libidn backend, which is available in the staging directory.

Also, pass TARGET="../util/" to MAKE_FLAGS. OpenWrt has it's own TARGET env var which clobbers the 'TARGET' var from prosody's build (specified as 'TARGET?=../util/')

Adding a test.sh to check for the correct version (since prosody mostly has lua scripts).


🧪 Run Testing Details

  • OpenWrt Version:
  • OpenWrt Target/Subtarget:
  • OpenWrt Device:

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

@commodo commodo force-pushed the fix-prosody-again branch from 831ef40 to f66d65a Compare May 3, 2026 06:54
@GeorgeSapkin
Copy link
Copy Markdown
Member

Thinking out loud. Maybe for the failing version checks in executables, have a version-specific override, like test_version.sh and leave test.sh for something more generic?

@commodo
Copy link
Copy Markdown
Contributor Author

commodo commented May 3, 2026

@GeorgeSapkin

Looks like the test.sh scripts are hanging.
Please check.
No idea if it is related to any recent change

I will merge this tomorrow (I guess).

@commodo
Copy link
Copy Markdown
Contributor Author

commodo commented May 3, 2026

i guess they timed out

@GeorgeSapkin
Copy link
Copy Markdown
Member

I canceled the tests. I'm testing my fixes with this PR now.

@GeorgeSapkin
Copy link
Copy Markdown
Member

Here's a working run with the changes from this PR and test-version.sh overrides both for idn and prosody:

PR with generic test improvements is here:

@Neustradamus

This comment was marked as low quality.

@commodo
Copy link
Copy Markdown
Contributor Author

commodo commented May 5, 2026

@commodo: Thanks for your work!

Can you check for the security fixes about this EOL branch?

And to look for Prosody IM 13.x?

Sure.
Good point

@commodo commodo force-pushed the fix-prosody-again branch 2 times, most recently from 27d678e to 18a009a Compare May 5, 2026 12:21
@commodo commodo changed the title prosody: fix build for 0.12.4 and add test.sh prosody: fix build, bump to to 0.12.6 and add test.sh May 5, 2026
@commodo
Copy link
Copy Markdown
Contributor Author

commodo commented May 5, 2026

@commodo: Thanks for your work!
Can you check for the security fixes about this EOL branch?

And to look for Prosody IM 13.x?

Sure. Good point

So, 0.12.6 for now.
I just want CI to pass; this one has been breaking for a while.

Later 13.x

@Neustradamus

This comment was marked as spam.

mod_s2s was refactored into a single mod_s2s.lua in the flat modules
directory in 0.12.x; remove the obsolete subdirectory install rule that
caused the package build to fail.

Also add util/human/ and util/prosodyctl/ which are new subdirectories
in 0.12.x not covered by the previous install rules.

Force libidn instead of ICU for stringprep

prosody's configure script auto-detects stringprep backends and prefers
ICU when available, generating -DUSE_STRINGPREP_ICU and including
<unicode/usprep.h>. The OpenWrt SDK staging directory does not provide
ICU development headers, so the build fails with:

  encodings.c:271:10: fatal error: unicode/usprep.h: No such file or directory

The Makefile DEPENDS already declares +libidn. Pass --with-idn=idn to
explicitly select the libidn backend, which is available in the staging
directory.

Also, pass TARGET="../util/" to MAKE_FLAGS. OpenWrt has it's own TARGET
env var which clobbers the 'TARGET' var from prosody's build (specified
as 'TARGET?=../util/')

Adding a test.sh to check for the correct version (since prosody mostly
has lua scripts).

Security release addressing multiple vulnerabilities. 0.12.6 is
likely the last release of the 0.12.x series (EOL June 2026).

Upstream advisory: https://prosody.im/security/

Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
@commodo commodo force-pushed the fix-prosody-again branch from 18a009a to 2169f32 Compare May 6, 2026 06:13
@commodo
Copy link
Copy Markdown
Contributor Author

commodo commented May 6, 2026

@GeorgeSapkin

Any objections if I merge this?

The tests seem to work (sort-of).
They seem to hang; this looks like it needs to wait for your PR to be merged?

@GeorgeSapkin
Copy link
Copy Markdown
Member

Tests worked in my fork with the changes from the aforementioned PR. I don't think we have to wait for it to be merged, and can merge this PR.

@commodo commodo merged commit 42daa80 into openwrt:master May 6, 2026
7 of 12 checks passed
@commodo commodo deleted the fix-prosody-again branch May 6, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants