Make GetIdAndPreferences async to handle library load and data sync#48
Open
RomainLofaso wants to merge 2 commits intoopenx:paffrom
Open
Make GetIdAndPreferences async to handle library load and data sync#48RomainLofaso wants to merge 2 commits intoopenx:paffrom
RomainLofaso wants to merge 2 commits intoopenx:paffrom
Conversation
|
This pull request has been inactive for an extended period and will be closed in 14 days if no activity occurs. To prevent closure, please:
Auto-generated by GitHub Cleaner - Notification 1/2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use asynchronous API of PAF.
Draft
I would like to discuss the used API before adding tests. Olivier suggested using Promises. Putting compatibility concerns aside, I am not sure that it fits all the cases due to the existing API with callbacks but it is worth to dig in.