Fix #482: Remove default admin for onboarding V2 (3/12)

[adhiamboperes]

Explanation

Fix #482

In the legacy onboarding flow, the admin profile is hardcoded into the profile chooser screen. In V2 of the onboarding flow, an admin user creates their profile during onboarding. This makes the hardcoded profile redundant, and this PR removes it.

Main Changes

1. Gating addProfile()

   • profileManagementController.addProfile() is now gated behind the enableOnboardingFlowV2 flag.
   • This ensures it is only called in the legacy flow.

2. Cleanup of profileNickname

   • The profileNickname argument (introduced in a previous PR to ensure the created profile had the correct display name) is no longer needed.
   • This PR removes its usages and updates the relevant tests.

3. Fix for App Data Reset Edge Case

   • Previously, deleting all profiles during an app data reset left the app in a bad state: the app was considered onboarded, but no profiles existed.
   • To address this, a new function resetOnboardingState has been added in AppStartupStateController.kt to reset the onboarding state.

Considered Approaches

There were multiple possible solutions for handling the reset logic:

• (a) UI-Layer Reset

  • Update alreadyOnboardedApp to false and call the function in the UI layer.
  • Minimal impact, no refactor required.
  • Requires keeping the delete profiles DataProvider and app startup state DataProvider in sync.
  • Harder to test the reset flow in ProfileLoginFragmentTest.kt.

• (b) Domain-Layer Reset

  • Update alreadyOnboardedApp to false inside profileManagementController.deleteAllProfiles().
  • Ensures the two providers are always in sync.
  • Violates single responsibility principle of deleteAllProfiles().

• (c) Refactor to Remove alreadyOnboardedApp

  • Remove the field and instead rely on whether the profiles list is empty.
  • Requires significant refactors across multiple areas, including handling both states of the enableAppAndOsDeprecation feature flag.
  • Startup logic would need to move away from onboardingFlowStore, adding complexity.

Option (a) was chosen because it:

• Requires the least amount of change.
• Minimizes side effects.
• Keeps the implementation cleaner, even though testing and DataProvider synchronization require extra care.

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Before	After
https://github.com/user-attachments/assets/a2f635e9-4078-49c3-b157-374f9f6b8ba9	https://github.com/user-attachments/assets/cce07588-912e-4b44-85b5-6007381106bc

[oppiabot]

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[github-actions]

Coverage Report

Results

Number of files assessed: 8
Overall Coverage: 91.57%
Coverage Analysis: PASS ✅

Passing coverage

Files with passing code coverage

File	Coverage	Lines Hit	Status	Min Required
AppStartupStateController.kt domain/src/main/java/org/oppia/android/domain/onboarding/AppStartupStateController.kt	91.57%	76 / 83	✅	70%

Exempted coverage

Files exempted from coverage

File	Exemption Reason
ProfileChooserFragment.kt app/src/main/java/org/oppia/android/app/profile/ProfileChooserFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileLoginFragmentPresenter.kt app/src/main/java/org/oppia/android/app/profile/ProfileLoginFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
ProfileChooserActivity.kt app/src/main/java/org/oppia/android/app/profile/ProfileChooserActivity.kt	This file is exempted from having a test file; skipping coverage check.
ProfileChooserActivityPresenter.kt app/src/main/java/org/oppia/android/app/profile/ProfileChooserActivityPresenter.kt	This file is exempted from having a test file; skipping coverage check.
SplashActivity.kt app/src/main/java/org/oppia/android/app/splash/SplashActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AdminIntroFragmentPresenter.kt app/src/main/java/org/oppia/android/app/onboarding/AdminIntroFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
AdminIntroFragment.kt app/src/main/java/org/oppia/android/app/onboarding/AdminIntroFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

[adhiamboperes]

@BenHenning, PTAL. This is probably the smallest PR in the entire project 😁.

[BenHenning]

Thanks @adhiamboperes! Just a few comments--PTAL.

[BenHenning]

Reminder check the checkboxes on the PR description as well.

Other than that, super cool to see an issue from 2019 get resolved! :D

[adhiamboperes]

@BenHenning, PTAL.

[github-actions]

Coverage Report

Results

Number of files assessed: 9
Overall Coverage: 91.57%
Coverage Analysis: PASS ✅

Passing coverage

Files with passing code coverage

File	Coverage	Lines Hit	Status	Min Required
AppStartupStateController.kt domain/src/main/java/org/oppia/android/domain/onboarding/AppStartupStateController.kt	91.57%	76 / 83	✅	70%

Exempted coverage

Files exempted from coverage

File	Exemption Reason
SplashActivity.kt app/src/main/java/org/oppia/android/app/splash/SplashActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileLoginFragment.kt app/src/main/java/org/oppia/android/app/profile/ProfileLoginFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileChooserFragment.kt app/src/main/java/org/oppia/android/app/profile/ProfileChooserFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileLoginFragmentPresenter.kt app/src/main/java/org/oppia/android/app/profile/ProfileLoginFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
ProfileChooserActivity.kt app/src/main/java/org/oppia/android/app/profile/ProfileChooserActivity.kt	This file is exempted from having a test file; skipping coverage check.
ProfileChooserActivityPresenter.kt app/src/main/java/org/oppia/android/app/profile/ProfileChooserActivityPresenter.kt	This file is exempted from having a test file; skipping coverage check.
AdminIntroFragmentPresenter.kt app/src/main/java/org/oppia/android/app/onboarding/AdminIntroFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
AdminIntroFragment.kt app/src/main/java/org/oppia/android/app/onboarding/AdminIntroFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

[oppiabot]

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[oppiabot]

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[oppiabot]

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[BenHenning]

Thanks @adhiamboperes! This LGTM.

[oppiabot]

Unassigning @BenHenning since they have already approved the PR.

[oppiabot]

Hi @adhiamboperes, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!