transport fix for live query #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is recived, so that if a buffer larger the a single operation is recived it will cause all updates to lag, this couses issues for the live query since it often recives an update for each registeration on the same connecion, changed it to parse the entire buffer til its end but only one chunk at a time
pull from main
Member
|
Tests on Travis won't pass. Could you please fix them to merge it? |
added 2 commits
July 22, 2015 22:49
…allow for context switching to not take too much time on the main js thread
Author
|
I have no idea why this change couses all those issues, researching it, ideas welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #36
The connection used to only read a single chunk of data when new data is recived.
So that if a buffer was larger then a single operation is recived it will cause all updates to lag indeifinitly.
This couses issues for the live query since it often recives an update for each registeration on the same connecion, I changed the code to parse the entire buffer til its end but only one chunk at a time.