Skip to content

Conversation

@needslyp
Copy link
Contributor

@needslyp needslyp commented Jul 5, 2023

No description provided.

Copy link
Collaborator

@MksmOrlov MksmOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge old branhes into your, we already have this changes. Rebase on develop, please

@needslyp needslyp requested a review from MksmOrlov July 27, 2023 09:28
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Make real values
  2. Write possible values for font type, size
  3. Remove lang_en for numbers. Use class number from ims
  4. nrel_system_name is not about text value in UI components. Rename this relation

@needslyp needslyp requested a review from MksmOrlov July 31, 2023 09:19
Copy link
Collaborator

@MksmOrlov MksmOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update documentation (make UI page) and changelog

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font size is not adaptive. I change it in the KB and see no difference on the interface

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reloading page I see the old values for a second, then they change to the actual from KB

}


async function fetchFontFamily() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write what possible values are for font type

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make one relation like concept_ui_component_text_value and use it. Do not copy it for the copyright panel, menu button and system name. Use only ine relation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree! Completely agree!

@needslyp needslyp requested a review from MksmOrlov August 31, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants