Skip to content

feat(web-domains-data): ds records - datagrid #20644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: feat/web-domain-data-2
Choose a base branch
from
Open

feat(web-domains-data): ds records - datagrid #20644

wants to merge 1 commit into from

Conversation

@louisbensiovh
Copy link
Contributor

@louisbensiovh louisbensiovh commented Nov 26, 2025 •
edited
Loading

Description

Allow user to see the Ds Records list with datagrid

Ticket Reference: #DCE-28

@louisbensiovh louisbensiovh requested a review from a team as a code owner November 26, 2025 13:42
@louisbensiovh louisbensiovh requested review from SBrendan, kb-ovh and nfoufeovh and removed request for a team November 26, 2025 13:42
@louisbensiovh louisbensiovh force-pushed the feat/DCE-28 branch 2 times, most recently from 6fedea9 to 81d13a4 Compare November 27, 2025 14:45
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 27, 2025
@louisbensiovh louisbensiovh force-pushed the feat/DCE-28 branch 2 times, most recently from f506f18 to df9f104 Compare November 27, 2025 15:23
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging and removed has conflicts Has conflicts to resolve before merging labels Nov 27, 2025
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 27, 2025
@louisbensiovh louisbensiovh force-pushed the feat/DCE-28 branch 3 times, most recently from fc16858 to 9ab072c Compare November 27, 2025 15:41
@kb-ovh kb-ovh force-pushed the feat/web-domain-data-2 branch from 8521b2f to d35717d Compare November 27, 2025 16:13
@kb-ovh kb-ovh requested review from a team as code owners November 27, 2025 16:13
@kb-ovh kb-ovh requested review from MaximeBajeux, aboungnaseng-ovhcloud, achrafHafedh, anooparveti and helabenkhalfallah and removed request for a team November 27, 2025 16:13
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging dependencies Pull requests that update a dependency file container labels Nov 27, 2025
@kb-ovh kb-ovh force-pushed the feat/web-domain-data-2 branch from d35717d to 228c68d Compare November 27, 2025 16:46
@louisbensiovh louisbensiovh force-pushed the feat/DCE-28 branch 5 times, most recently from f4d2682 to a9440b0 Compare December 1, 2025 13:38
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 1, 2025
@louisbensiovh louisbensiovh force-pushed the feat/DCE-28 branch 2 times, most recently from ae7edb1 to f07f976 Compare December 1, 2025 13:49
@github-actions github-actions bot removed dependencies Pull requests that update a dependency file container labels Dec 1, 2025
kb-ovh
kb-ovh reviewed Dec 1, 2025
View reviewed changes
packages/manager/apps/web-domains/public/translations/domain/Messages_fr_FR.json Outdated
"domain_tab_hosts_modal_delete_information_message": "Êtes-vous sur de voulour supprimer cet hôte ?",
"domain_tab_hosts_modal_delete_success_message": "L'hôte est en cours de suppression",
"domain_tab_hosts_modal_delete_error_message": "Une erreur a été détectée lors de la suppression de l'hôte"
"domain_tab_hosts_modal_delete_error_message": "Une erreur a été détectée lors de la suppression de l'hôte",
Copy link
Contributor

@kb-ovh kb-ovh Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Une erreur est survenue lors de la suppression de l'hôte" ?

kb-ovh
kb-ovh reviewed Dec 2, 2025
View reviewed changes
...s/manager/apps/web-domains/src/domain/hooks/domainTabs/useDomainDsRecordsDatagridColumns.tsx Outdated
id: 'flags',
cell: (props: TDsDataInterface) => (
<DataGridTextCell>
{props.flags} - Key Signing Key (KSK)
Copy link
Contributor

@kb-ovh kb-ovh Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no translation here ?

kb-ovh
kb-ovh reviewed Dec 2, 2025
View reviewed changes
...s/manager/apps/web-domains/src/domain/hooks/domainTabs/useDomainDsRecordsDatagridColumns.tsx Outdated
label: t('domain_dsrecords_table_header_flags'),
},
{
id: 'algorithme',
Copy link
Contributor

@kb-ovh kb-ovh Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id: 'algorithme',
id: 'algorithm',

kb-ovh
kb-ovh reviewed Dec 2, 2025
View reviewed changes
...s/manager/apps/web-domains/src/domain/hooks/domainTabs/useDomainDsRecordsDatagridColumns.tsx Outdated
id: 1,
label: t(`${NAMESPACES.ACTIONS}:modify`),
},

Copy link
Contributor

@kb-ovh kb-ovh Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

kb-ovh
kb-ovh reviewed Dec 2, 2025
View reviewed changes
packages/manager/apps/web-domains/src/domain/pages/domainTabs/dsRecords/dsRecordsListing.tsx Outdated
if (dsRecord.algorithm === 3) {
return {
...dsRecord,
supportedAlgorithm: { name: 'RSASHZA3457', number: 3 },
Copy link
Contributor

@kb-ovh kb-ovh Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use const instead and explain why this value is not in the supportedAlgorithms const please :)

@louisbensiovh
feat(web-domains-data): ds records - datagrid
77fd155 
ref:#DCE-28

Signed-off-by: Louis BENSI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kb-ovh kb-ovh kb-ovh left review comments

@SBrendan SBrendan Awaiting requested review from SBrendan SBrendan is a code owner automatically assigned from ovh/dev-manager-web-domain

@nfoufeovh nfoufeovh Awaiting requested review from nfoufeovh nfoufeovh is a code owner automatically assigned from ovh/dev-manager-web-domain

@helabenkhalfallah helabenkhalfallah Awaiting requested review from helabenkhalfallah helabenkhalfallah was automatically assigned from ovh/dev-manager-control-tower

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti was automatically assigned from ovh/dev-manager-control-tower

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud Awaiting requested review from aboungnaseng-ovhcloud aboungnaseng-ovhcloud was automatically assigned from ovh/dev-manager-control-tower

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux was automatically assigned from ovh/dev-manager-gcj-all

@achrafHafedh achrafHafedh Awaiting requested review from achrafHafedh achrafHafedh was automatically assigned from ovh/dev-manager-gcj-all

Assignees

No one assigned

Labels

feature New feature translation required universe-web-cloud

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@louisbensiovh @kb-ovh