feat(communication): add guided tour #20647
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aottr
requested review from
MaximeBajeux,
aboungnaseng-ovhcloud,
achrafHafedh,
anooparveti,
helabenkhalfallah and
sachinrameshn
and removed request for
a team
aottr
force-pushed
the
feat/MANAGER-18777
branch
from
fd2fe00 to
b3d00b1
Compare
aottr
force-pushed
the
feat/MANAGER-18777
branch
from
b3d00b1 to
7db3e3d
Compare
packages/manager/apps/communication/src/components/guidedTour/GuidedTour.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/communication/src/hooks/useGuidedTour/useGuidedTour.context.tsx
Outdated
Show resolved
Hide resolved
MehdiZaghouani
approved these changes
Dec 1, 2025
ref: #MANAGER-18777 Signed-off-by: Dustin Kroger <[email protected]>
aottr
force-pushed
the
feat/MANAGER-18777
branch
from
7db3e3d to
21ccb97
Compare
anooparveti
reviewed
Dec 2, 2025
| stepElement.style.height = `${rect.height + offset}px`; | ||
| }; | ||
|
|
||
| export const computePopoverPosition = ({ |
Contributor
There was a problem hiding this comment.
nitpick(suggestion): Add explanation behind this logic building for better readability.
anooparveti
reviewed
Dec 2, 2025
Comment on lines
+8
to
+19
| export const getMePreferences = async (preferenceKey: string): Promise<boolean> => { | ||
| try { | ||
| const { data } = await apiClient.v6.get<MePreferences>( | ||
| `/me/preferences/manager/${preferenceKey}`, | ||
| ); | ||
| return data.value ? data.value.toLowerCase() === 'true' : false; | ||
| } catch (error) { | ||
| if ((error as ApiError).status == 404) { | ||
| return false; | ||
| } | ||
| throw error; | ||
| } |
Contributor
There was a problem hiding this comment.
suggestion: This could probably be added in common-api module as it can be used in other µ-apps as well like Container.
Contributor
Author
There was a problem hiding this comment.
If we add it to the common-api module, I'd add a proper generic type definition since some of the preferences on this API contain stringified JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #MANAGER-18777
Description
Ticket Reference: #...
Additional Information