feat(os): add refresh button on objects #20786
Open
+78
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel95200x
force-pushed
the
feat/DATATR-2633
branch
from
18cb4f4 to
9f8424e
Compare
lionel95200x
force-pushed
the
feat/DATATR-2633
branch
from
9f8424e to
0f2979a
Compare
jperchoc
reviewed
Dec 4, 2025
...er/apps/pci-object-storage/src/pages/object-storage/storage/swiftId/objects/Objects.page.tsx
Show resolved
Hide resolved
Comment on lines
13
to
15
| export const useSwiftData = ( | ||
| queryOptions?: OptionsFor<typeof getSwiftStorage>, | ||
| ) => { |
Contributor
There was a problem hiding this comment.
I don't see it used anywhere, is it needed ?
...nager/apps/pci-object-storage/src/pages/object-storage/storage/s3Id/objects/Objects.page.tsx
Show resolved
Hide resolved
Comment on lines
5
to
6
| onRefresh: () => void; | ||
| isRefetching: boolean; |
Contributor
There was a problem hiding this comment.
The props should align with common button semantics:
Suggested change
| onRefresh: () => void; | |
| isRefetching: boolean; | |
| onClick: () => void; | |
| isLoading: boolean; |
| export default function S3ObjectVersionList({ objects }: ObjectsListProps) { | ||
| export default function S3ObjectVersionList({ | ||
| objects, | ||
| onRefresh, |
Contributor
There was a problem hiding this comment.
Suggested change
| onRefresh, | |
| onRefreshClicked, |
lionel95200x
force-pushed
the
feat/DATATR-2633
branch
2 times, most recently
from
7627b2c to
76bf52a
Compare
ref: #DATATR-2633 Signed-off-by: Lionel Bueno <[email protected]>
lionel95200x
force-pushed
the
feat/DATATR-2633
branch
from
76bf52a to
737933f
Compare
jperchoc
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #DATATR-2633
Description
Ticket Reference: #DATATR-2633
Additional Information