refactor(ai): remove debug-logger abstraction — PR 2–4 modules#417
Merged
ianwhitedeveloper merged 2 commits intoai-testing-framework-implementation-consolidationfrom Feb 26, 2026
Conversation
13 tasks
ianwhitedeveloper
force-pushed
the
pr/ai-debug-logger-removal
branch
from
a985629 to
ecd2c58
Compare
ianwhitedeveloper
force-pushed
the
ai-testing-framework-implementation-consolidation
branch
from
a96a49d to
6c81837
Compare
debug/logFile/logger params were never in the formal requirements, never
exposed via the CLI, and never tested end-to-end. logFile was UAT
scaffolding already broken in two places. Removing the abstraction
simplifies every public signature and eliminates logger threading.
- Delete debug-logger.js and debug-logger.test.js (−417 lines)
- Drop debug/logFile/logger params from execute-agent, agent-parser,
aggregation, extraction-parser, validation public signatures
- Convert user-visible progress messages to console.log/console.warn
- Delete internal diagnostic noise throughout
- Remove debug/debugLog fields from constants.js defaults and schema
- Extract truncateOutput helper in execute-agent.js (eliminates duplication)
- Convert resolveImportPaths to named params { importPaths, projectRoot }
- Replace manual zodError.issues mapping with z.prettifyError in aggregation
- Full expected-value assertions and allNoop spread pattern in test files
Co-authored-by: Cursor <cursoragent@cursor.com>
ianwhitedeveloper
force-pushed
the
pr/ai-debug-logger-removal
branch
from
ecd2c58 to
82202d2
Compare
- Document parseOutput signature in executeAgent docblock - Extract authGuidance constant from validation.js; import in test to decouple expected value from inline string - console.log -> console.warn on auth failure path - Restore smoke-test comment in verifyAgentAuthentication - Normalize Try() call site in extraction-parser.test.js Made-with: Cursor
ianwhitedeveloper
merged commit a6b8a8f
into
ai-testing-framework-implementation-consolidation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prerequisite cleanup for PR 5 (#416). Must merge before PR 5 resumes review.
Removes the
debug-loggerabstraction that was introduced in PR 2 but never covered by formal requirements, never exposed via the CLI, and never tested end-to-end.logFilewas UAT scaffolding already broken in two places on the old branch. Stripping it simplifies every public signature, eliminates logger threading, and resolves all logger-related WIP items from the consolidation plan.What's in This PR
Deleted
source/debug-logger.jsandsource/debug-logger.test.js— removed entirely (−417 lines across 11 files).Modified — signature cleanup (PR 2–4 modules)
source/execute-agent.js— dropdebug/logFile/loggerparams fromexecuteAgent,runAgentProcess,spawnProcess,processAgentOutput; extracttruncateOutputhelper (eliminates duplication)source/agent-parser.js— droploggerfromunwrapAgentResultandunwrapRawOutputsource/aggregation.js— droplogger; replace manualzodError.issuesmapping withz.prettifyError; switch tosafeParsepatternsource/extraction-parser.js— convertresolveImportPathsto named params{ importPaths, projectRoot }; drop positionaldebug/loggerparamsource/validation.js— dropdebugparam fromverifyAgentAuthentication; convertlogger.*calls toconsole.logsource/constants.js— removedebug/debugLogfields from defaults and schemaTests updated
source/agent-parser.test.js— drop per-test logger localssource/aggregation.test.js— dropcreateMockLogger; full expected-value assertionssource/execute-agent.test.js— drop logger argssource/extraction-parser.test.js— dropnoopLogger; updateresolveImportPathscall sites to named paramssource/limit-concurrency.test.js— full expected-value assertionssource/validation.test.js— dropdebugarg; usehandleAIErrorsrouting patternWhy This is a Separate PR
These changes touch already-merged modules from PRs 2–4. They are logically independent from PR 5's new modules (
test-extractor.js,ai-runner.js) and are cleaner to review in isolation. PR 5 depends on the cleaned-up signatures established here.Test Results
All existing tests pass with the signatures updated:
Made with Cursor