fix(transport-manager): blacklist addresses on PeerIdMismatch negotiation errors#543
Open
WilliamNwoke wants to merge 1 commit intoparitytech:masterfrom
Open
fix(transport-manager): blacklist addresses on PeerIdMismatch negotiation errors#543WilliamNwoke wants to merge 1 commit intoparitytech:masterfrom
WilliamNwoke wants to merge 1 commit intoparitytech:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #492
Fixes an issue where
PeerIdMismatchnegotiation errors did not penalize address scores effectively due to a +100 (connection established) and -100 (dial failure) cancellation, causing invalid peer addresses to be retried indefinitely. SincePeerIdMismatchis a permanent structural failure (the address belongs to a different peer), it is now treated asADDRESS_FAILURE(i32::MIN) instead of a transientCONNECTION_FAILURE. Additionally,AddressStore::insertnow sets the score absolutely toi32::MIN(rather than accumulating) when handlingADDRESS_FAILURE, ensuring prior positive scores cannot offset the penalty. New tests verify permanent blacklisting forPeerIdMismatchwhile preserving normal behavior for transient failures.