test: wait for explicit calls in directory test #1442
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hopefully fixes the flakiness since we explicitly wait for each step rather than hoping the delay was right.
43081j
force-pushed
the
flaky-buns
branch
6 times, most recently
from
2766a1a to
c08a6c4
Compare
Collaborator
Author
|
well i can reproduce the bun problem now so will dig into it before i merge this or #1441 it feels like a bun bug but not sure yet |
Collaborator
Author
|
its a bug in bun, or many bugs. the usual suspect im going to merge this and we can fix our bun tests when bun themselves fix their runtime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully fixes the flakiness since we explicitly wait for each
step rather than hoping the delay was right.
Fixes #1437 too