i_1262 Improve sandbox scripts for better reporting CPU time accuracy#1263
Open
johnbrvc wants to merge 1 commit into
Open
i_1262 Improve sandbox scripts for better reporting CPU time accuracy#1263johnbrvc wants to merge 1 commit into
johnbrvc wants to merge 1 commit into
Conversation
Both the pc2sandbox and pc2sandbox_interactive scripts have been modified to only put the bare minimum amount of work in the cgroup. Previously, some debug logging and other bash related stuff was charged to the cgroup. CI: Use CPU # (0-(N-1)) instead of ordinal (1-N) to determine the CPU to pin to. Change taskset to use the -c CPU# option instead of the default "mask" option for clarity. CI: better handling of error conditions in the pc2sandbox_interactive script to create the resource summary report even on failures and PC2 wall time limit exceeded. Previously, resource were not created in these cases. (This makes the Web Judge Interface better). CI: Add TDEBUG falg to control timing debugging. It is ON by default and logs stuff to the sandbox.log file. It's mostly keeping track of the cgroup cpu.stat file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what the PR does
Both the
pc2sandbox.shandpc2sandbox_interactive.shscripts have been modified to only put the bare minimum amount of work in the cgroup. Previously, some debug logging and other bash related stuff was charged to the cgroup.CI: Use CPU # (0-(N-1)) instead of ordinal (1-N) to determine the CPU to pin to. Change
tasksetto use the-c CPU#option instead of the default "mask" option for clarity.CI: better handling of error conditions in the
pc2sandbox_interactive.shscript to create the resource summary report even on failures and PC2 wall time limit exceeded. Previously, resource were not created in these cases. (This makes the Web Judge Interface better).CI: Add
TDEBUGflag to control timing debugging. It is ON by default and logs stuff to thesandbox.logfile. It's mostly keeping track of the cgroupcpu.statfile.Issue which the PR addresses
Fixes #1262
Environment in which the PR was developed (OS,IDE, Java version, etc.)
Linux 24.04.3
Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)
samps/src/hello.cppprogram.bashprompt using the Linux "time" program:time ./a.outsamps/src/hello.cppprogram for the "hello" problem.bashcommand prompt, change to the "execute" folder where the judge executed the submission.sandbox.logfile.