Fix segmentation violation when stat fails on source object for override determination#838
Open
NeonWizard wants to merge 1 commit intopeak:masterfrom
Open
Fix segmentation violation when stat fails on source object for override determination#838NeonWizard wants to merge 1 commit intopeak:masterfrom
NeonWizard wants to merge 1 commit intopeak:masterfrom
Conversation
terryrankine
added a commit
to terryrankine/s5cmd
that referenced
this pull request
Mar 18, 2026
Add nil check for srcObj after statObject returns successfully but with no object found, preventing a segfault when comparing source and destination metadata. (peak#838) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
--if-size-differor--if-source-newer, the source and destination objects havestatcalled on them to fetch metadata used for the override determination. Sometimes, this call can return an object not found error on the source object, despite us knowing the file exists. This can be either due to rate limiting, service disruptions, or the file being moved on the source before the stat can be called. When this happens, the code dereferences nil for the comparison since the object not found error was swallowed. I added a check to prevent this and raise an error about the unexpected stat failure.Segfault:
This should resolve issue #689