fix: honor --profile flag for AWS credential and config loading#847
Open
houseofeng wants to merge 1 commit intopeak:masterfrom
Open
fix: honor --profile flag for AWS credential and config loading#847houseofeng wants to merge 1 commit intopeak:masterfrom
houseofeng wants to merge 1 commit intopeak:masterfrom
Conversation
- Allow --profile to use AWS credential chain instead of forcing ~/.aws/credentials - Add Profile field to session.Options for proper shared config loading - Maintains backward compatibility for --credentials-file usage Resolves issue where --profile flag was ignored and application always used default profile from shared config.
houseofeng
requested review from
ilkinulas and
seruman
and removed request for
a team
Author
|
Looking at the output of the failed integration test, I don't believe that has to do with the code changes. Please let me know if I'm mistaken. |
terryrankine
added a commit
to terryrankine/s5cmd
that referenced
this pull request
Mar 18, 2026
Remove Profile from the credential-file-only branch so --profile alone uses the SDK's shared config resolution (SSO, assume-role, etc.) instead of being forced through NewSharedCredentials. Pass Profile into session.Options so the SDK picks up the correct profile. (peak#847) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue where --profile flag was ignored and application always used default profile from shared config if no credentials file was specified.