Consolidate message deduplication into shared MessageDeduplicator #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extend MessageDeduplicator with configurable maxAge/maxCount params - Add timestampFor() method for content key time-window checks - Add record() method to store entries with specific timestamps - Replace ChatViewModel's custom contentLRU implementation with MessageDeduplicator - Remove ~35 lines of duplicate LRU code from ChatViewModel This consolidates 2 separate deduplication implementations into one reusable, thread-safe component.
…ationStateManager Merge two singleton location managers into a unified LocationStateManager: - CoreLocation permissions and channel computation - Channel selection and teleport state tracking - Bookmark persistence and friendly name resolution - Reverse geocoding (shared, deduplicated) Provides backward-compatible typealiases so existing code continues to work: - typealias LocationChannelManager = LocationStateManager - typealias GeohashBookmarksStore = LocationStateManager Reduces 4 location-related files to 3 (keeping LocationNotesManager and GeohashParticipantTracker separate due to different lifecycles). Files: 2 deleted, 1 created (~525 lines -> ~420 lines)
Update call site to use resolveBookmarkNameIfNeeded instead of resolveNameIfNeeded, which was renamed during the consolidation.
Allow tests to create instances with custom UserDefaults storage for isolated testing of bookmark functionality.
jackjackbits
deleted the
claude/simplify-codebase-012QAJ8ihBcE4VzdufcixKHt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates 2 separate deduplication implementations into one
reusable, thread-safe component.