fix(macos): Propagate environment objects to sheet presentations #900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes crash on macOS when presenting sheets due to missing
@EnvironmentObjectpropagation.Problem
The macOS app (v1.4.4) crashes with
EnvironmentObject.error()when presenting SwiftUI sheets. This is a known SwiftUI behavior difference where macOS requires explicit environment object passing while iOS sometimes propagates them automatically.Solution
Added
.environmentObject(viewModel)to 8 sheet and fullScreenCover presentations inContentView.swift:Testing Performed
Platforms Affected
Impact
Before/After
Before: Opening any sheet/modal crashed the app with
EnvironmentObject.error()After: All sheets open correctly, full functionality restored on macOS