fix(openai): Tool name or arguments might be empty/null

[tcx4c70]

Some providers might return empty/null values in streaming delta (I guess it's to keep schema consistent?). For example, streaming data for a request might be:

data: { ... "choices":[{"index":0,"delta":{"role":"assistant","tool_calls":[{"index":0, ... "function":{"name":"get_database_schema","arguments":""}}]}}] ... }
data: { ... "choices":[{"index":0,"delta":{"tool_calls":[{"index":0,"function":{"name":null,"arguments":"{}"}}]}}] ... }
data: { ... "choices":[{"index":0,"finish_reason":"tool_calls","delta":{}}] ... }
data: [DONE]

Then pgAdmin will combine the delta to a tool call with name "null" and arguments "{}", which leads to a error that can't find the tool.

Though I don't find the official doc that mentions we should skip null value in delta, the official openai python sdk skips null values [1].

This commit is to skip null values in streaming delta to avoid empty/null tool name or arguments.

[1] https://github.com/openai/openai-python/blob/58184ad545ee2abd98e171ee09766f259d7f38cd/src/openai/lib/streaming/_deltas.py#L6

Summary by CodeRabbit

• Bug Fixes
  • Fixed an issue where empty values were incorrectly overwriting valid tool call information when streaming responses from OpenAI, improving the reliability of tool call handling.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7298c6e9-e62b-49c7-adeb-a2cd98b08d62

📥 Commits

Reviewing files that changed from the base of the PR and between d59fcf3 and 65cc8b2.

📒 Files selected for processing (1)

• web/pgadmin/llm/providers/openai.py

---

📝 Walkthrough

Walkthrough

The change adds truthiness checks to tool call field assignments in OpenAI's SSE stream parsing to prevent empty-string overwrites and concatenations while processing tool call deltas.

Changes

Cohort / File(s)	Summary
OpenAI Stream Parser web/pgadmin/llm/providers/openai.py	Added conditional checks in _read_openai_stream to only update tool call name field and append to arguments field when their corresponding values are truthy, preventing empty-string overwrites during delta accumulation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A nimble fix for streaming flows,
Where empty strings no longer creep,
Tool calls now safely grow and grow,
With truthiness to guard so deep!
✨ Two lines to keep the deltas sweet ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: handling empty/null values in OpenAI tool name or arguments fields to prevent errors.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}