Document missing file mode element for descriptors #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

jstangroome wants to merge 1 commit into php:master from jstangroome:jstangroome-proc_open-file-mode

jstangroome commented Jan 7, 2026

No description provided.


          Document missing file mode element for descriptors

lacatoire approved these changes

View reviewed changes

Contributor

lacatoire commented Jan 29, 2026

LGTM it matches the implementation in https://github.com/php/php-src/blob/master/ext/standard/proc_open.c#L1054
see set_proc_descriptor_from_array() and set_proc_descriptor_to_pipe().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet