Fix setcookie() documentation for invalid options in PHP 8.0+#5104
Merged
Girgias merged 6 commits intophp:masterfrom Jan 30, 2026
Merged
Fix setcookie() documentation for invalid options in PHP 8.0+#5104Girgias merged 6 commits intophp:masterfrom
Girgias merged 6 commits intophp:masterfrom
Conversation
Girgias
requested changes
Jan 14, 2026
Member
Girgias
left a comment
There was a problem hiding this comment.
Thanks for working on the doc! Please amend following the comments. :)
Contributor
Author
|
Thanks for the review @Girgias |
Girgias
reviewed
Jan 30, 2026
Girgias
reviewed
Jan 30, 2026
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Girgias
reviewed
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setcookie() documentation states that passing an invalid key in the options array triggers an E_WARNING.
Since PHP 8.0, invalid option keys throw a ValueError instead. This PR updates the documentation to accurately reflect the current behavior while preserving the pre-8.0 behavior for reference.
Issue: #4985