Extend Iterator::rewind note to mention NoRewindIterator #5110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Girgias merged 5 commits into php:master from lacatoire:clarify-iterator-rewind-note-

Jan 30, 2026

Contributor

lacatoire commented Jan 15, 2026

This extends the note on Iterator::rewind() to clarify that foreach always rewinds the iterator before iteration and points users to NoRewindIterator when rewinding should be avoided.

Issue: #3308


          Extend Iterator::rewind note to mention NoRewindIterator

c894da1

Girgias reviewed

View reviewed changes

language/predefined/iterator/rewind.xml Outdated Show resolved Hide resolved

lacatoire commented

View reviewed changes

language/predefined/iterator/rewind.xml Outdated Show resolved Hide resolved


          Apply suggestion from @lacatoire

13d91bd

lacatoire commented

View reviewed changes

language/predefined/iterator/rewind.xml Outdated Show resolved Hide resolved


          Apply suggestion from @lacatoire

43f5e40

lacatoire commented

View reviewed changes

language/predefined/iterator/rewind.xml Outdated Show resolved Hide resolved


          Apply suggestion from @lacatoire

774bac1

lacatoire commented

View reviewed changes

language/predefined/iterator/rewind.xml Outdated Show resolved Hide resolved


          Apply suggestion from @lacatoire

e92b75d

Girgias approved these changes

View reviewed changes

Girgias merged commit 7fbb16f into php:master

2 checks passed

lacatoire deleted the clarify-iterator-rewind-note- branch

January 30, 2026 10:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet