Skip to content

Conversation

@divinity76
Copy link
Contributor

@divinity76 divinity76 commented Jan 20, 2026

tested on 8.3.4.

@lacatoire
Copy link
Contributor

LGTM. In php-src ext/standard/basic_functions.stub.php line 3836, the signature is:

  function fsockopen(string $hostname, int $port = -1, &$error_code = null, &$error_message = null, ?float $timeout = null) {}                                                                            

  The error_code and error_message parameters have no explicit type but default to null. The current documentation shows int and string with = null, which is inconsistent. Changing to int|null and string|null correctly reflects that these parameters accept null as their default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants