proc_close: "waits", not "closes". Also grammar fix in Returns.#5482
Open
SinusPi wants to merge 2 commits intophp:masterfrom
Open
proc_close: "waits", not "closes". Also grammar fix in Returns.#5482SinusPi wants to merge 2 commits intophp:masterfrom
SinusPi wants to merge 2 commits intophp:masterfrom
Conversation
The function waits (waitpid) for a process to terminate, it does not do any closing. The description is a little misleading.
lacatoire
reviewed
Apr 21, 2026
Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
jordikroon
requested changes
May 6, 2026
Member
jordikroon
left a comment
jordikroon
left a comment
There was a problem hiding this comment.
All good, just one small nit; when changing copy that is within a <para>. We should also change to <simpara>. See it as a change from <div> to <p>.
| @@ -46,7 +46,7 @@ | |||
| &reftitle.returnvalues; | |||
| <para> | |||
Member
There was a problem hiding this comment.
Suggested change
| <para> | |
| <simpara> |
| Returns the termination status of the process that was run. In case of | ||
| an error then <literal>-1</literal> is returned. | ||
| an error <literal>-1</literal> is returned. | ||
| </para> |
Member
There was a problem hiding this comment.
Suggested change
| </para> | |
| </simpara> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function waits (waitpid) for a process to terminate, it does not do any closing. The description is a little misleading.