-
Notifications
You must be signed in to change notification settings - Fork 864
CI: Add docbook-cs linting #5524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jordikroon
wants to merge
5
commits into
php:master
Choose a base branch
from
jordikroon:feature/docbook-cs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b39bb70
add docbook-cs linting
jordikroon b329689
refactor docbook-cs workflow
jordikroon 5d4c2d5
refactor docbook-cs workflow
jordikroon 9e28026
pin docbook-cs dependencies and add cs2pr
jordikroon 122c89a
update docbook-cs XML namespace and add schema validation
jordikroon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| # https://docs.github.com/en/actions | ||
|
|
||
| name: "DocBook Lint" | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - "master" | ||
| pull_request: | ||
| branches: | ||
| - "master" | ||
|
|
||
| permissions: | ||
| contents: "read" | ||
|
|
||
| concurrency: | ||
| group: "${{ github.workflow }}-${{ github.ref }}" | ||
| cancel-in-progress: true | ||
|
|
||
|
jordikroon marked this conversation as resolved.
|
||
| jobs: | ||
| docbook-cs: | ||
| name: "DocBook Style Check" | ||
| runs-on: "ubuntu-latest" | ||
|
|
||
| strategy: | ||
| matrix: | ||
| language: | ||
| - "en" | ||
|
|
||
| steps: | ||
| - name: "Checkout php/doc-${{ matrix.language }}" | ||
| uses: "actions/checkout@v6" | ||
| with: | ||
| ref: "${{ github.event.pull_request.head.sha }}" | ||
| path: "${{ matrix.language }}" | ||
| fetch-depth: 50 | ||
|
|
||
| - name: "Checkout php/doc-base" | ||
| uses: "actions/checkout@v6" | ||
| with: | ||
| path: "doc-base" | ||
| repository: "php/doc-base" | ||
|
|
||
| - name: "Fetch base branch with merge-base" | ||
| working-directory: "${{ matrix.language }}" | ||
| run: | | ||
| git fetch origin ${{ github.base_ref }} --depth=50 | ||
| # Deepen until we find the merge-base (handles long-lived PRs) | ||
| for i in 1 2 3 4 5; do | ||
| if git merge-base origin/${{ github.base_ref }} HEAD >/dev/null 2>&1; then | ||
| break | ||
| fi | ||
| git fetch --deepen=100 origin ${{ github.base_ref }} | ||
| done | ||
|
|
||
| - name: "Setup PHP" | ||
| uses: "shivammathur/setup-php@v2" | ||
| with: | ||
| php-version: "8.5" | ||
| extensions: "dom, libxml, simplexml" | ||
| tools: composer:v2 | ||
|
|
||
| - name: "Build documentation" | ||
| run: | | ||
| php doc-base/configure.php \ | ||
| --disable-libxml-check \ | ||
| --enable-xml-details \ | ||
| --redirect-stderr-to-stdout \ | ||
| --with-lang=${{ matrix.language }} | ||
|
|
||
| - name: "Install docbook-cs" | ||
| working-directory: "${{ matrix.language }}" | ||
| run: composer require jordikroon/docbook-cs:^1.1 staabm/annotate-pull-request-from-checkstyle:^1.8 | ||
|
|
||
| - name: "Run docbook-cs with diff" | ||
| working-directory: "${{ matrix.language }}" | ||
| run: | | ||
| set -o pipefail | ||
| git diff origin/${{ github.base_ref }}...HEAD | vendor/bin/docbook-cs \ | ||
| --report=checkstyle \ | ||
| --diff \ | ||
| --no-colors > docbook-report.xml || true | ||
|
|
||
| - name: "Upload report" | ||
| if: ${{ ! cancelled() }} | ||
| uses: "actions/upload-artifact@v7" | ||
| with: | ||
| name: "docbook-report" | ||
| path: "${{ matrix.language }}/docbook-report.xml" | ||
|
|
||
| - name: "Annotate PR with violations" | ||
| if: ${{ ! cancelled() }} | ||
| working-directory: "${{ matrix.language }}" | ||
| run: vendor/bin/cs2pr docbook-report.xml --colorize --prepend-filename | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <docbookcs xmlns="https://jordikroon.github.io/docbook-cs/config" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="https://jordikroon.github.io/docbook-cs/config | ||
| https://jordikroon.github.io/docbook-cs/config.xsd"> | ||
|
|
||
| <project> | ||
| <directory alias="doc-en">en</directory> | ||
| <directory>doc-base</directory> | ||
| </project> | ||
|
|
||
| <sniffs> | ||
| <sniff class="DocbookCS\Sniff\SimparaSniff" /> | ||
| <sniff class="DocbookCS\Sniff\ExceptionNameSniff" /> | ||
| <sniff class="DocbookCS\Sniff\AttributeOrderSniff" /> | ||
| <sniff class="DocbookCS\Sniff\WhitespaceSniff" /> | ||
| </sniffs> | ||
|
|
||
| <paths> | ||
| <path>.</path> | ||
| </paths> | ||
|
|
||
| <entities> | ||
| <file>contributors.ent</file> | ||
| <file>extensions.ent</file> | ||
| <file>language-defs.ent</file> | ||
| <file>language-snippets.ent</file> | ||
| <directory>../doc-base/entities/</directory> | ||
| <file>../doc-base/temp/file-entities.ent</file> | ||
| <directory>../doc-base/temp/file-entities</directory> | ||
| </entities> | ||
|
|
||
| <exclude> | ||
| <pattern>*/wkhtmltox/bits/*</pattern> | ||
| <pattern>output/*</pattern> | ||
| </exclude> | ||
|
|
||
| </docbookcs> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I purposely added a newline here as this is consistent with
integrate.yaml. If still preferred I can apply this change though.