Fix GH-20906: Assertion failure when messing up output buffers #20908
+79
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Jan 11, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
I wonder if a better change for master is to make the highlighter not rely on the output buffering as it seems it gets discarded anyway in some cases.
ext/standard/basic_functions.c
Outdated
|
|
||
| if (i) { | ||
| php_output_start_default(); | ||
| if (php_output_start_default() != SUCCESS) { |
Member
Author
|
It's not getting discarded. Either returned as string or sent to the output |
Member
Right, I meant "discarded" when returning it as a string, which I guess ideally shouldn't rely on the output buffering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.