[block_pass] Relink successors after block becomes empty #20909
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvement of phpGH-20850 for master only.
arnaud-lb
reviewed
Jan 12, 2026
| if (recompute_successors) { | ||
| for (b = blocks; b < end; b++) { | ||
| for (int s = 0; s < b->successors_count; s++) { | ||
| get_target_block(&cfg, b, s, &opt_count); |
Member
There was a problem hiding this comment.
It's possible that get_target_block() will update successors to a non-target block. I'm wondering if this could become an issue. Should we propagate the ZEND_BB_TARGET flag to the new successor?
Member
Author
There was a problem hiding this comment.
Oh, good catch. get_target_block() should probably take care of that. Edit: Ah, I misunderstood. Yeah you're correct, this needs fixing.
Member
There was a problem hiding this comment.
Note, that your previous fix relays on ZEND_BB_TARGET flag, that may be not accurately set for empty blocks and their followers. Updating it lazily in get_target_block() won't work for all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement of GH-20850 for master only.