Skip to content

Comments

Chore: update everything#3

Merged
discordier merged 14 commits intomasterfrom
feature/upgrades
Feb 10, 2026
Merged

Chore: update everything#3
discordier merged 14 commits intomasterfrom
feature/upgrades

Conversation

@discordier
Copy link
Member

@discordier discordier commented Feb 2, 2026

  • Adds dependabot
  • Bump github action versions
  • Fix findings for current tool versions on PHP 7.4 up to PHP 8.5

@discordier discordier self-assigned this Feb 2, 2026
@discordier discordier requested a review from dmolineus February 2, 2026 22:59
It was incorrectly specified as "Gnupg", which is wrong but worked due
to the case insensitive nature of class names in PHP.
@discordier
Copy link
Member Author

@dmolineus We have two problems here with psalm which I do not know how to tackle.

First one: Psalm when running with ext-gnupg:

psalm.xml
---------

[0:0] MAJOR reported by psalm:
    UnusedIssueHandlerSuppression: Suppressed issue type "UndefinedDocblockClass" for  was not thrown.

This is expected, because the class indeed does exist - extension is loaded.
If I remove the suppression though, we'll get UndefinedDocblockClass for the other job, where the extension is not loaded.

Suppressing the UnusedIssueHandlerSuppression does not work btw. :)

So how can I properly handle this?

Second one:

src/Wrapper/GnuPGExtensionWrapper.php
-------------------------------------

[62:50] MAJOR reported by psalm:
    PossiblyFalseArgument: Argument 2 of gnupg::verify cannot be false, possibly string value expected

This is plain wrong in psalm. PHP docs clearly state to set the signature to false. See here.

I'm open to suppressing this, have not done so though as we might have to change it when handling the first issue anyway.

@dmolineus
Copy link
Contributor

For the first issue, I guess we have to use the psalm attribute findUnusedIssueHandlerSuppression="false". For the second problem, let's silence it.

@discordier
Copy link
Member Author

@dmolineus
Tried suppressions in d50b9bf to no avail.

Tbh, I feel it is worse now.

If I don't suppress, it complains. If I suppress, it complains that the issue has never been raised despite specifying findUnusedPsalmSuppress="false".

I'm really clueless.

@discordier
Copy link
Member Author

Just realized, I was using the wrong attribute... you said findUnusedIssueHandlerSuppression="false" and I added findUnusedPsalmSuppress="false" instead.

Changed and now all is green. 💯

@discordier discordier merged commit d5594bd into master Feb 10, 2026
8 checks passed
@discordier discordier deleted the feature/upgrades branch February 10, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants