-
Notifications
You must be signed in to change notification settings - Fork 6.1k
planner: Adjust out of range for time decay #64486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @terry1purcell. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #64486 +/- ##
================================================
+ Coverage 72.6893% 72.9179% +0.2286%
================================================
Files 1866 1888 +22
Lines 506220 514212 +7992
================================================
+ Hits 367968 374953 +6985
- Misses 115870 116153 +283
- Partials 22382 23106 +724
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@terry1purcell: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #64378
Problem Summary:
What changed and how does it work?
Out of range estimation uses a time decay concept - the further out of range you search, the lower the percentage estimate. This time decay can cause an issue for customers with very large tables who may run ANALYZE less often. If the predicate uses a search range that moves forward each day, but the ANALYZE is rerun - then the estimate will be reduced each day that the predicate moves away from the statistics.
This PR adds a compensation for the time decay by evaluating the estimate if the range was closer to the histogram high range, and adjusts the estimate accordingly.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.