Skip to content

Fix exports#39

Closed
singiamtel wants to merge 1 commit intopkmn:mainfrom
singiamtel:bun_tests
Closed

Fix exports#39
singiamtel wants to merge 1 commit intopkmn:mainfrom
singiamtel:bun_tests

Conversation

@singiamtel
Copy link
Contributor

Please describe your fix:

Properly export TS types as such

Bug:

This breaks testing on bun. Not very relevant but still neat to get it fixed

Testing:

Run `npm run build && bun test``, it should be green now

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation where necessary
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have split off unrelated changes into their own PRs and done my best to make this PR as
    focused as possible while still being useful

@scheibo
Copy link
Contributor

scheibo commented May 2, 2025

In general Jarred wants issues like these to be filed against Bun instead of the respective projects.

Also, is this really the only place in the whole tree that needs to be updated? Im suprised nothing else exports types?

@singiamtel
Copy link
Contributor Author

I'll try to file a min repro against Bun instead. Some other projects didn't pass the tests in bun, I didn't investigate much

@singiamtel singiamtel closed this May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants