feat: upgrade static-php-cli submodule to v2.7.5 #285
+37
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcdawkins
force-pushed
the
upgrade-static-php-cli
branch
from
473b2ad to
2674885
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the static-php-cli submodule from v1.3.3 to v2.7.5 and migrates the build process to use the new unified CLI tooling instead of the legacy Docker-based scripts.
Key Changes:
- Upgraded static-php-cli submodule to v2.7.5 (commit c5ae719b)
- Migrated from custom Docker build process to
spc-alpine-dockertool - Replaced extensions.txt with craft.yml for configuration
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ext/static-php-cli | Submodule updated to v2.7.5 (c5ae719b) |
| ext/extensions.txt | Removed legacy extension configuration file |
| ext/craft.yml | New configuration file for static-php-cli v2.7.5 build process |
| Makefile | Updated Linux PHP build target to use spc-alpine-docker tool |
| Dockerfile.php | Removed obsolete custom Docker build configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update the static-php-cli submodule from commit 4c55f4a2 to v2.7.5 (c5ae719b). Changes made to adapt to v2.7.5: - Replace legacy Docker build script approach with spc-alpine-docker tool. - Add ext/craft.yml to configure PHP extensions (curl, filter, openssl, pcntl, phar, posix, zlib). - Update Makefile to use new build command via spc-alpine-docker. The new version uses a unified craft.yml configuration format and bin/spc tool instead of the legacy docker/ directory with manual build scripts. Co-Authored-By: Claude <[email protected]>
Use static-php-cli's craft command instead of separate download and build commands. This eliminates the duplication of the extensions list and aligns with the configuration-driven approach in craft.yml. Also remove invalid with-strip-php option from craft.yml (stripping is the default behavior). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Document craft-options based on static-php-cli documentation: doctor checks the environment, download fetches php-src and libraries, and build compiles the static binary. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
pjcdawkins
force-pushed
the
upgrade-static-php-cli
branch
from
a34b43b to
7015c47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the static-php-cli submodule from commit 4c55f4a2 (v1.3.3+132 commits) to v2.7.5 (c5ae719b) and updates the build process to work with the new architecture.
(@crazywhalecc helpfully pointed out our SPC version is rather old)
Changes Made
Upgraded submodule: Updated ext/static-php-cli from commit 4c55f4a2 to v2.7.5 (c5ae719b)
Created ext/craft.yml: New configuration file for static-php-cli v2.7.5 that specifies:
Updated Makefile: Replaced the legacy Docker build process with the new
spc-alpine-dockertool:bin/spc-alpine-docker buildcommand from static-php-cli v2.7.5Removed obsolete files:
Key Differences in v2.7.5
docker/directory with manual scripts (download.sh, compile-php.sh, etc.) has been removedbin/spcCLI tool with Docker wrappers (spc-alpine-docker, spc-gnu-docker)Testing
To test the build, run:
This will trigger the Linux PHP build using the new spc-alpine-docker tool. The build will:
The build may take 10-15 minutes on first run as it sets up the Docker environment.