Prevent email reports when consolidated view ineligible #5882
+142
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerosol
approved these changes
Nov 12, 2025
lib/workers/send_email_report.ex
Outdated
Comment on lines
233
to
234
| not Plausible.Sites.consolidated?(site) or | ||
| Plausible.ConsolidatedView.ok_to_display?(site.team) |
Member
There was a problem hiding this comment.
Maybe something verbose but expressive like:
Suggested change
| not Plausible.Sites.consolidated?(site) or | |
| Plausible.ConsolidatedView.ok_to_display?(site.team) | |
| Plausible.Sites.regular?(site) or | |
| (Plausible.Sites.consolidated?(site) and Plausible.ConsolidatedView.ok_to_display?(site.team)) |
|
|
||
| :ok | ||
| defp handle_notification(%TrafficChangeNotification{type: :drop} = notification, now) do | ||
| current_visitors = Clickhouse.current_visitors_12h(notification.site) |
Member
There was a problem hiding this comment.
ooh, does this already work with multiple site ids?
lib/workers/send_email_report.ex
Outdated
|
|
||
| if report do | ||
| with %Plausible.Site{} <- site, | ||
| %{} = report <- Map.get(site, report_type), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When email reports (such as weekly reports, or traffic drop notifications) have been scheduled for consolidated views, we need to check upon sending, whether the consolidated view is still "eligible".
Tests
Changelog
Documentation
Dark mode