fix: resolve TypeScript errors in entities-treeview#1847
Merged
willeastcott merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses TypeScript correctness in the editor’s scene hierarchy tree view (EntitiesTreeView) by adding explicit types/interfaces for tree items and constructor args, and by tightening internal member typing to eliminate “Property does not exist…” errors.
Changes:
- Introduces
EntityTreeViewItemandEntitiesTreeViewArgsto replace ad-hoc intersection types and to type TreeView constructor arguments. - Adds explicit, typed private member declarations for
EntitiesTreeViewto satisfy TS and improve readability. - Adjusts enabled-state propagation logic to derive recursive disabled state from the entity hierarchy (not the TreeView element).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
willeastcott
force-pushed
the
fix/entities-treeview-types
branch
from
7ee5334 to
04b5ad1
Compare
willeastcott
force-pushed
the
fix/entities-treeview-types
branch
from
04b5ad1 to
4cfaa9a
Compare
willeastcott
force-pushed
the
fix/entities-treeview-types
branch
from
4cfaa9a to
3626ffb
Compare
willeastcott
force-pushed
the
fix/entities-treeview-types
branch
from
3626ffb to
056238e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
willeastcott
force-pushed
the
fix/entities-treeview-types
branch
from
056238e to
ec6a3db
Compare
willeastcott
force-pushed
the
fix/entities-treeview-types
branch
from
ec6a3db to
fe72255
Compare
willeastcott
force-pushed
the
fix/entities-treeview-types
branch
from
fe72255 to
d814bb3
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
willeastcott
force-pushed
the
fix/entities-treeview-types
branch
from
d814bb3 to
277319e
Compare
Add explicit property declarations and type annotations to EntitiesTreeView to fix all 152 "Property X does not exist on type Y" errors. - Define EntityTreeViewItem interface extending TreeViewItem with entity and _containerUsers properties - Define EntitiesTreeViewArgs interface extending TreeViewArgs - Add typed private property declarations for all class members - Replace ad-hoc intersection types with EntityTreeViewItem - Add proper casts for protected member access, EventTarget, and editor-api runtime properties (apiAsset, apiEntity) - Fix _updateTreeItemEnabledState to use entity enabled state instead of the TreeView element's own enabled state for child recursion Made-with: Cursor
willeastcott
force-pushed
the
fix/entities-treeview-types
branch
from
277319e to
c283ec5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 152
"Property X does not exist on type Y"TypeScript errors inentities-treeview.tsby adding explicit property declarations and proper type annotations.EntityTreeViewIteminterface (extendsTreeViewItemwithentityand_containerUsers)EntitiesTreeViewArgsinterface (extendsTreeViewArgswithentities,assets,history,dropManager,writePermissions)privateproperty declarations for all class members, following the pattern used inAttributesInspectorandEntityInspectorTreeViewItem & { entity: Observer }intersection types withEntityTreeViewItem_containerContents),EventTarget→Node, and editor-api runtime properties (apiAsset,apiEntity)_updateTreeItemEnabledStateto use the entity's own enabled state instead of theTreeViewelement'senabledproperty when computingchildParentDisabledfor recursive descentTest plan
npm run type:checkpasses with zero errors inentities-treeview.ts