-
-
Notifications
You must be signed in to change notification settings - Fork 9
Fixes issues with Projects created using Volto 19 #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| npm i -g corepack@latest && corepack enable pnpm | ||
| corepack use pnpm@{{ cookiecutter.__version_pnpm }} | ||
| corepack prepare pnpm@{{ cookiecutter.__version_pnpm }} --activate | ||
| CI=1 npm i -g corepack@latest && corepack enable pnpm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericof we don't have them in 19 anymore in any of our current projects and works well. And if so, we have to adjust the versions in case it's 18 or 19.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see now, they are already adjusted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sneridagh I had a problem to generate the image with 19, that is why I kept it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not, and I removed it from all of our projects... that's why I was asking. It would be worth to see what was wrong in there.
sneridagh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
package.jsonfromproject_settingsproject_settings