Skip to content

Conversation

@ericof
Copy link
Member

@ericof ericof commented Dec 2, 2025

  • Remove package.json from project_settings
  • Fixes to Dockefile on project_settings

@ericof ericof requested a review from davisagli December 2, 2025 19:17
@ericof ericof requested a review from sneridagh as a code owner December 2, 2025 19:17
@ericof ericof added the 01 type: bug something does not work label Dec 2, 2025
npm i -g corepack@latest && corepack enable pnpm
corepack use pnpm@{{ cookiecutter.__version_pnpm }}
corepack prepare pnpm@{{ cookiecutter.__version_pnpm }} --activate
CI=1 npm i -g corepack@latest && corepack enable pnpm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericof we don't have them in 19 anymore in any of our current projects and works well. And if so, we have to adjust the versions in case it's 18 or 19.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see now, they are already adjusted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sneridagh I had a problem to generate the image with 19, that is why I kept it here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not, and I removed it from all of our projects... that's why I was asking. It would be worth to see what was wrong in there.

Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericof ericof merged commit 5ed86dc into main Dec 3, 2025
39 checks passed
@ericof ericof deleted the volto-19-fixes branch December 3, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

01 type: bug something does not work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants